IRVINE, Calif.—As Irvine looks to make more than 1,000 apartment units more affordable for middle-income people through a new housing proposal, critics say it could have detrimental financial impacts on the city. “Middle-income housing,” also known as “workforce housing,” are residential units rented out at below-market rates to the “missing middle”—renters who are earning too…